-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align System.CommandLine version with SDK #103759
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
</Dependency> | ||
<!-- Intermediate is necessary for source build. --> | ||
<Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.440701"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still necessary for source build? There is a separate (newer) version for source-build in the SDK repo as well: https://github.com/dotnet/sdk/blob/d0ccce00860ffdee00d7328705e841e4f785a999/src/SourceBuild/content/eng/Versions.props#L29
Yes we still need this for source-build. We should investigate why dependency flow doesn't work. |
I think it's the only one using libraries feed Line 18 in ae6ad88
What I understood from @adamsitnik is that they should be kept in sync across dotnet repos (dotnet/command-line-api#2146), so probably configuring auto-update (like dotnet/sdk has) is the right solution. |
The subscription was disabled for main. I just enabled. |
The update is now part of #103574. Let's close this PR. Thanks for bringing this up :) |
Awesome! 👍 |
Correct.
I've not been involved in System.CommandLine for almost a year now, but my understanding was that S.CL publishes a new package after every PR gets merged and at that time we were introducing a lot of breaking changes and did want to address each of them separately in every repo. We wanted to do that on demand, when something that was merged was needed. But this could have changed since then @baronfel @jonsequitur |
cc @ViktorHofer, @akoeplinger for some reason, auto-update is not working in runtime, as in; dotnet/sdk#40075.